Skip to content

8366094: Sealed graph for nested types creates broken links #28134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

8366094: Sealed graph for nested types creates broken links #28134

wants to merge 3 commits into from

Conversation

@hns
Copy link
Member

@hns hns commented Nov 4, 2025 •
edited by openjdk bot
Loading

Please review a change to fix broken links in sealed type hierarchy graphs for nested types. The problem is that SVG files for nested types use the names of enclosing types as parent directories. Therefore, links from nested type SVGs must have a matching ../ for each enclosing type.

Fixed graphs for some nested sealed types:

There is currently no test coverage for the sealed graph taglet. I tested the fix manually, a test should be added with JDK-8366828.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366094: Sealed graph for nested types creates broken links (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28134/head:pull/28134
$ git checkout pull/28134

Update a local copy of the PR:
$ git checkout pull/28134
$ git pull https://git.openjdk.org/jdk.git pull/28134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28134

View PR using the GUI difftool:
$ git pr show -t 28134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28134.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025 •
edited
Loading

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366094: Sealed graph for nested types creates broken links

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 218 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org build build-dev@openjdk.org labels Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025 •
edited
Loading

@hns The following labels will be automatically applied to this pull request:

  • build
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2025 •
edited
Loading

Webrevs

@hns
Copy link
Member Author

hns commented Nov 14, 2025

I added a comment and updated the description to better explain the problem and fix.

liach
liach approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are weird right now. This fix is good, we can fix the svg file locations later.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2025
@hns
Copy link
Member Author

hns commented Nov 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

Going to push as commit ac6f5e9.
Since your change was applied there have been 218 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2025
@openjdk openjdk bot closed this Nov 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2025
@openjdk
Copy link

openjdk bot commented Nov 18, 2025

@hns Pushed as commit ac6f5e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liach liach liach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build build-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hns @liach